Conversation
github-actions
bot
changed the base branch from
master
to
version/0-48-0-RC1
Collaborator
|
It's not clear to me what other authentication issues could happen that ought to be captured by the poller. The ticket does not make it clear which cases we should expect to have happen and handle. The Putting this up for early review. Maybe it's enough for now. |
Contributor
|
@MDrakos I know it's been a while; do you recall if there was still work missing from this PR? |
Contributor
|
@MDrakos ping |
Member
Author
|
@Naatan Bah sorry not sure how I lost track of this. I don't think there was any functional work left to do just maybe some improvements do how the code is structured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample:
